Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #151 Council update #153

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Closes #151 Council update #153

merged 6 commits into from
Apr 29, 2024

Conversation

NNaikp
Copy link
Collaborator

@NNaikp NNaikp commented Apr 29, 2024

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
  • Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
  • Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, add your own tag! We occasionally tidy up all tags for consistency.
  • Add a short description for your blog post in the description field at the top of the markdown document.
  • Blog post is short, personalized, reproducible and readable
  • Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
    This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
  • Address all merge conflicts and resolve appropriately
  • Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@NNaikp
Copy link
Collaborator Author

NNaikp commented Apr 29, 2024

@rossfarrugia Would you like more details about the companies added?

@NNaikp
Copy link
Collaborator Author

NNaikp commented Apr 29, 2024

@bms63 Seems like I don't have rights to assign reviewers and Development in this repo 🤷‍♂️

@bms63
Copy link
Collaborator

bms63 commented Apr 29, 2024

@NNaikp you have access now

@bms63 bms63 changed the title Closes #151 Closes #151 Council update Apr 29, 2024
@bms63
Copy link
Collaborator

bms63 commented Apr 29, 2024

Looks fab to me! @rossfarrugia @MichaelRimler @mstackhouse do you all need to take a look or shall we just merge in?

@bms63 bms63 self-requested a review April 29, 2024 12:20
Copy link
Contributor

@rossfarrugia rossfarrugia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NNaikp looks good to me, i left some comments/suggestions for conisderation. i dont think we need to add too much more on the companies themselves as anyone could google to learn more about them

@NNaikp NNaikp requested review from rossfarrugia and bms63 April 29, 2024 12:48
@bms63 bms63 merged commit e6469aa into pharmaverse:main Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog Post: New pharmaverse council members announcement
6 participants